Use SPDX for licenses #2122
Merged
Use SPDX for licenses #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piponazo
requested review from
clanmills,
1div0,
kevinbackhouse,
kmilos and
hassec
Codecov Report
@@ Coverage Diff @@
## main #2122 +/- ##
=======================================
Coverage 63.98% 63.98%
=======================================
Files 97 97
Lines 19084 19084
Branches 9750 9750
=======================================
Hits 12211 12211
Misses 4599 4599
Partials 2274 2274
Continue to review full report at Codecov.
|
piponazo
force-pushed
the
mainLicenseSPDX
branch
from
539e513
to
3be66bf
Compare
piponazo
force-pushed
the
mainLicenseSPDX
branch
from
3be66bf
to
65e8f6b
Compare
Thanks! I would like to kindly ask you to re-approve. I had to amend the last commit to fix the compilation in one of the CI jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it has been discussed recently in the team chat, I am proposing here the usage of the SPDX standard for the definition of the project licenses: https://spdx.dev/ . It seems to be the way to go for specifying the license in open source projects and many projects are already using it (between them the Linux kernel).
I am proposing this change because I found a bit irritating to have such duplication in the comments for each file. Furthermore, the years appearing in the copyright were different in each of the modified files.