clang-tidy: C array to std::array conversions #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funny. This exposed bugs. |
Codecov Report
@@ Coverage Diff @@
## main #2154 +/- ##
=======================================
Coverage 62.65% 62.65%
=======================================
Files 97 97
Lines 19722 19721 -1
Branches 9710 9710
=======================================
Hits 12357 12357
+ Misses 5133 5132 -1
Partials 2232 2232
Continue to review full report at Codecov.
|
Signed-off-by: Rosen Penev <[email protected]>
piponazo
approved these changes
Mar 18, 2022
| for (auto&& filteredIfd : filteredIfds) { | ||
| #ifdef EXIV2_DEBUG_MESSAGES | ||
| std::cerr << "Warning: Exif IFD " << filteredIfds << " not encoded\n"; | ||
| std::cerr << "Warning: Exif IFD " << filteredIfd << " not encoded\n"; |
There was a problem hiding this comment.
LoL, I wonder what was happening here before 🙉
There was a problem hiding this comment.
Probably same thing since there's only one member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rosen Penev [email protected]