Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[027] Fix integer overflow #2179 #2194

Merged
merged 1 commit into from
Apr 6, 2022
Merged

[027] Fix integer overflow #2179 #2194

merged 1 commit into from
Apr 6, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Apr 6, 2022

Fix #2179 on 0.27-maintenance

I dit not add the unit tests here as I did in #2181 because the lack of modern C++ support makes the work more cumbersome.

@piponazo piponazo added this to the v0.27.6 milestone Apr 6, 2022
@piponazo piponazo self-assigned this Apr 6, 2022
@piponazo piponazo changed the base branch from main to 0.27-maintenance April 6, 2022 12:32
@piponazo piponazo closed this Apr 6, 2022
@piponazo piponazo reopened this Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #2194 (e54f5c9) into 0.27-maintenance (3409ddd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           0.27-maintenance    #2194   +/-   ##
=================================================
  Coverage             58.87%   58.88%           
=================================================
  Files                   149      149           
  Lines                 23205    23209    +4     
  Branches              12713    12717    +4     
=================================================
+ Hits                  13662    13666    +4     
  Misses                 6702     6702           
  Partials               2841     2841           
Impacted Files Coverage Δ
src/jpgimage.cpp 69.93% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3409ddd...e54f5c9. Read the comment docs.

@piponazo piponazo changed the title 027 fix2179 [027] Fix integer overflow #2179 Apr 6, 2022
@piponazo piponazo requested review from hassec, kmilos and neheb April 6, 2022 13:05
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piponazo piponazo merged commit 036af47 into 0.27-maintenance Apr 6, 2022
@piponazo piponazo deleted the 027_fix2179 branch April 6, 2022 13:17
@kmilos kmilos added the bug label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer overflow in Photoshop::setIptcIrb
2 participants