add missing memory header for std::unique_ptr in values.hpp #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76f01fd removes the <memory> header which is required to use std::unique_ptr for some builds (e.g. archlinux using gcc 12.1.0).
neheb
approved these changes
May 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #2236 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 117 117
Lines 19593 19593
Branches 9551 9551
=======================================
Hits 12426 12426
Misses 5098 5098
Partials 2069 2069
Continue to review full report at Codecov.
|
piponazo
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
76f01fd removes the memory header
which is required to use std::unique_ptr for some builds
(e.g. archlinux using gcc 12.1.0).
Due to this some CI nightly builds are also failing.