Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert with enforce #2269

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Replace assert with enforce #2269

merged 2 commits into from
Jul 7, 2022

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes #2268

@kevinbackhouse kevinbackhouse added this to the v0.27.6 milestone Jul 6, 2022
@kevinbackhouse kevinbackhouse added bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify labels Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2269 (aca8845) into 0.27-maintenance (575395f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2269      +/-   ##
====================================================
+ Coverage             58.88%   58.89%   +0.01%     
====================================================
  Files                   149      149              
  Lines                 23203    23203              
  Branches              12711    12711              
====================================================
+ Hits                  13662    13666       +4     
+ Misses                 6702     6700       -2     
+ Partials               2839     2837       -2
Impacted Files Coverage Δ
src/jp2image.cpp 67.84% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575395f...aca8845. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 26adf0c into Exiv2:0.27-maintenance Jul 7, 2022
@kevinbackhouse kevinbackhouse deleted the jp2image-assert branch July 7, 2022 09:58
@mergify mergify bot mentioned this pull request Jul 7, 2022
Merged
@kevinbackhouse kevinbackhouse restored the jp2image-assert branch July 7, 2022 10:00
@kevinbackhouse kevinbackhouse linked an issue Jul 7, 2022 that may be closed by this pull request
assertion failure in debug build #2268
Closed
piponazo
piponazo reviewed Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I added that assert recently while I was fixing few other things related to the JP2 support. According to the specification that box must be of that size

kevinbackhouse added a commit that referenced this pull request Jul 8, 2022
@kevinbackhouse
Merge pull request #2272 from Exiv2/mergify/bp/main/pr-2269
a22aea0 
Replace assert with enforce (backport #2269)
@nehaljwani nehaljwani mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo left review comments

@hassec hassec hassec approved these changes

Assignees
No one assigned
Labels
bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Milestone
v0.27.6
Development

Successfully merging this pull request may close these issues.

assertion failure in debug build
3 participants
@kevinbackhouse @piponazo @hassec