Fix some "unsafe vector access" warnings #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
+ Coverage 63.46% 63.48% +0.01%
==========================================
Files 118 118
Lines 19598 19595 -3
Branches 9556 9557 +1
==========================================
+ Hits 12438 12440 +2
+ Misses 5094 5091 -3
+ Partials 2066 2064 -2
Continue to review full report at Codecov.
|
kevinbackhouse
force-pushed
the
vector-access
branch
from
c73f8d6
to
b9b2d77
Compare
piponazo
approved these changes
Jul 9, 2022
| for (int i = 0; i < 16; i++) { | ||
| value[tolower(hexdigits[i])] = i + 1; | ||
| value[toupper(hexdigits[i])] = i + 1; | ||
| for (int i = 0; i < 10; i++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few of the "unsafe vector access" warnings flagged by CodeQL.