various manual cleanups #2278
Merged
various manual cleanups #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 63.52% 63.53% +0.01%
==========================================
Files 118 118
Lines 19600 19599 -1
Branches 9560 9562 +2
==========================================
+ Hits 12450 12453 +3
+ Misses 5082 5079 -3
+ Partials 2068 2067 -1
Continue to review full report at Codecov.
|
neheb
force-pushed
the
cl
branch
8 times, most recently
from
07bdb73
to
8d9553f
Compare
|
Updated. Additionally removed some lambdas. |
Signed-off-by: Rosen Penev <[email protected]>
Mostly deleted member functions Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
|
Removed const ref change. I disagree but w/e. |
Signed-off-by: Rosen Penev <[email protected]>
neheb
force-pushed
the
cl
branch
4 times, most recently
from
90c3e90
to
a8d6012
Compare
Signed-off-by: Rosen Penev <[email protected]>
Small cleanup Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Rosen Penev <[email protected]>
kevinbackhouse
approved these changes
Jul 15, 2022
I'd be happy to approve the change if you add a test. Right now that code is untested, which makes me nervous about changing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.