get rid of extern const #2302
Merged
get rid of extern const #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
- Coverage 63.42% 63.42% -0.01%
==========================================
Files 118 118
Lines 19637 19637
Branches 9607 9606 -1
==========================================
- Hits 12455 12454 -1
- Misses 5111 5112 +1
Partials 2071 2071
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It looked good to me, but some windows jobs are failing. |
Looks like some pre C++11 thing. Also fix formatting of these by adding , at the end of the arrays. Signed-off-by: Rosen Penev <[email protected]>
|
Fixed MSVC. Looks like it hates defining forward declared extern const as constexpr. |
kevinbackhouse
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some pre C++11 thing.
Also fix formatting of these by adding , at the end of the arrays.
Signed-off-by: Rosen Penev [email protected]