Use std::unordered_map for TiffTreeStruct lookup #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 63.41% 63.42%
=======================================
Files 118 118
Lines 19635 19634 -1
Branches 9606 9607 +1
=======================================
+ Hits 12451 12452 +1
+ Misses 5113 5112 -1
+ Partials 2071 2070 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neheb
reviewed
Aug 3, 2022
src/tiffimage_int.hpp
Outdated
| using Key = std::pair<uint32_t, IfdId>; | ||
| //! Comparison operator to compare a TiffTreeStruct with a TiffTreeStruct::Key | ||
| bool operator==(const Key& key) const; | ||
| const IfdId parentGroup_; //!< Parent group |
There was a problem hiding this comment.
You're right: I didn't need to do that. I also didn't need to add the constructor. I've removed them.
neheb
reviewed
Aug 4, 2022
|
⚔️ Conflicts |
neheb
reviewed
Aug 4, 2022
src/tiffimage_int.cpp
Outdated
| @@ -1830,8 +1830,8 @@ void TiffCreator::getPath(TiffPath& tiffPath, uint32_t extendedTag, IfdId group, | |||
| tiffPath.push(TiffPathItem(extendedTag, group)); | |||
There was a problem hiding this comment.
Oh this is funny. clang-tidy should but is not recommending emplace() here.
kevinbackhouse
force-pushed
the
tiffTreeStruct
branch
from
e8069d0
to
48070a2
Compare
|
rebased to fix the merge conflict |
neheb
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as #2299: use
std::unordered_mapfor faster lookup.