Use Safe::add() in tiffvisitor_int.cpp #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 62705a6 into 9767e37 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## main #2390 +/- ##
==========================================
+ Coverage 64.37% 64.40% +0.03%
==========================================
Files 119 119
Lines 21090 21087 -3
Branches 10399 10397 -2
==========================================
+ Hits 13577 13582 +5
+ Misses 5363 5355 -8
Partials 2150 2150
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiffvisitor_int.cpphas a couple of hand-coded integer overflow checks, the first of which didn't actually work correctly. This PR replaces them withSafe::add. It has caused some of the test files to produce different error messages than before, so there are a few test changes.The diff is best viewed with whitespace changes hidden, because I added a try-catch which has changed the indentation.