replace while loop with for range. #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
force-pushed
the
4
branch
2 times, most recently
from
e030008
to
3c80608
Compare
|
Those test failures indicate something is wrong. |
mergify
bot
dismissed
piponazo’s stale review
Pull request has been modified.
neheb
force-pushed
the
4
branch
2 times, most recently
from
e9adb54
to
734e071
Compare
less indentation Signed-off-by: Rosen Penev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 64.28% 64.27% -0.01%
==========================================
Files 119 119
Lines 21135 21132 -3
Branches 10430 10430
==========================================
- Hits 13586 13583 -3
Misses 5400 5400
Partials 2149 2149
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piponazo
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rosen Penev [email protected]