Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the interface of tiffcomposite_int.hpp to use size_t #2400

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

kevinbackhouse
Copy link
Collaborator

A lot of these values are file offsets, so I think it's cleaner to use size_t. Overall, it reduces the number of static_casts.

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #2400 (1992ae3) into main (62705a6) will decrease coverage by 0.12%.
The diff coverage is 92.80%.

@@            Coverage Diff             @@
##             main    #2400      +/-   ##
==========================================
- Coverage   64.40%   64.28%   -0.13%     
==========================================
  Files         119      119              
  Lines       21087    21135      +48     
  Branches    10397    10430      +33     
==========================================
+ Hits        13582    13586       +4     
- Misses       5355     5400      +45     
+ Partials     2150     2149       -1     
Impacted Files Coverage Δ
src/makernote_int.hpp 92.30% <ø> (ø)
src/tiffvisitor_int.cpp 79.78% <69.23%> (ø)
src/makernote_int.cpp 66.34% <87.50%> (ø)
src/tiffcomposite_int.cpp 75.99% <95.83%> (-0.03%) ⬇️
src/convert.cpp 51.40% <100.00%> (ø)
src/tiffcomposite_int.hpp 92.72% <100.00%> (ø)
src/tiffimage_int.cpp 79.58% <100.00%> (ø)
src/tiffvisitor_int.hpp 100.00% <100.00%> (ø)
src/bmffimage.cpp 68.26% <0.00%> (-7.49%) ⬇️
src/xmp.cpp 76.54% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neheb neheb merged commit abd817d into Exiv2:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants