Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Exif.SonyMisc3c.* and Exif.Sony(1|2).SonyModelID #2420

Merged

Conversation

postscript-dev
Copy link
Collaborator

Modernize code and synchronize with ExifTool.

@postscript-dev postscript-dev added makerNote Anything related to one of the various supported MakerNote formats prettyPrinter Anything related to the output formatting of a value labels Nov 11, 2022
@postscript-dev postscript-dev added this to the v1.00 milestone Nov 11, 2022
@postscript-dev postscript-dev self-assigned this Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #2420 (ebc3436) into main (026cee3) will increase coverage by 0.04%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main    #2420      +/-   ##
==========================================
+ Coverage   64.46%   64.51%   +0.04%     
==========================================
  Files         119      119              
  Lines       21139    21115      -24     
  Branches    10435    10420      -15     
==========================================
- Hits        13627    13622       -5     
+ Misses       5353     5336      -17     
+ Partials     2159     2157       -2     
Impacted Files Coverage Δ
src/sonymn_int.cpp 79.79% <70.58%> (+2.27%) ⬆️
src/makernote_int.cpp 66.34% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@postscript-dev
Copy link
Collaborator Author

As the Cygwin error is not caused by this PR, can someone review this please.

@postscript-dev postscript-dev marked this pull request as ready for review November 12, 2022 16:03
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@postscript-dev postscript-dev merged commit 83d7915 into Exiv2:main Nov 13, 2022
@postscript-dev postscript-dev deleted the update_sony_tags_using_exiftool branch November 14, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
makerNote Anything related to one of the various supported MakerNote formats prettyPrinter Anything related to the output formatting of a value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants