Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiv2 v0.27.6 #2463

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Exiv2 v0.27.6 #2463

merged 3 commits into from
Jan 18, 2023

Conversation

nehaljwani
Copy link
Collaborator

@nehaljwani nehaljwani commented Jan 16, 2023

It is time to cut a release 🙂

xref: #2406

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #2463 (d2ed6f4) into 0.27-maintenance (eae83b4) will increase coverage by 1.02%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2463      +/-   ##
====================================================
+ Coverage             58.89%   59.92%   +1.02%     
====================================================
  Files                   149      149              
  Lines                 23203    23921     +718     
  Branches              12711    12664      -47     
====================================================
+ Hits                  13666    14334     +668     
+ Misses                 6700     6692       -8     
- Partials               2837     2895      +58     
Impacted Files Coverage Δ
src/preview.cpp 51.30% <100.00%> (+2.32%) ⬆️
include/exiv2/pgfimage.hpp 0.00% <0.00%> (-100.00%) ⬇️
unitTests/test_helper_functions.cpp 66.66% <0.00%> (-13.34%) ⬇️
unitTests/test_futils.cpp 63.85% <0.00%> (-5.59%) ⬇️
include/exiv2/slice.hpp 87.28% <0.00%> (-4.24%) ⬇️
samples/Jzon.h 32.55% <0.00%> (-2.33%) ⬇️
samples/iptcprint.cpp 85.71% <0.00%> (-1.79%) ⬇️
unitTests/test_FileIo.cpp 64.28% <0.00%> (-1.43%) ⬇️
include/exiv2/error.hpp 54.54% <0.00%> (-1.02%) ⬇️
unitTests/test_jp2image.cpp 82.53% <0.00%> (-0.48%) ⬇️
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nehaljwani
Copy link
Collaborator Author

The failures in the macOS release build in CI are consistent and I haven't been able to reproduce them locally.

Combo macOS | x64 | Release:

build/bin/exiv2 -f -pp test/data/exiv2-pre-in-xmp.xmp
Preview 1: image/jpeg, 150x91 pixels, 4602 bytes

Combo macOS | x64 | Debug:

build/bin/exiv2 -f -pp test/data/exiv2-pre-in-xmp.xmp
Preview 1: image/jpeg, 150x91 pixels, 4745 bytes

Anyone know what's going on here? cc @postscript-dev, @kmilos, @piponazo, @neheb, @kevinbackhouse

@piponazo
Copy link
Collaborator

First time that I see this Mac CI errors. I could try to reproduce locally too, now that I have a Mac at home. I will let you know if I find the time to do it.

@nehaljwani
Copy link
Collaborator Author

I was able to reproduce the problem with Apple Clang 14.0.0
More details at: https://stackoverflow.com/q/75153729/1005215

@neheb
Copy link
Collaborator

neheb commented Jan 18, 2023

I remember converting this to std::array. vector seems better here because of the constructor.

@nehaljwani nehaljwani requested a review from neheb January 18, 2023 08:45
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@kmilos
Copy link
Collaborator

kmilos commented Jan 18, 2023

Finally, I know this is a worn out subject, but should we perhaps make ENABLE_BMFF=ON the default for this release and on this branch as well?

@nehaljwani
Copy link
Collaborator Author

For a patch release, I'd rather not. But I'm open to cutting a minor release with that flip.

@kevinbackhouse
Copy link
Collaborator

@nehaljwani: nice work tracking down that macOS bug! Amazing that it's actually caused by a compiler bug!

@postscript-dev
Copy link
Collaborator

@nehaljwani
Thanks for your work on the new release.

One minor thing, would it be possible to change my contributor name from Peter to Peter S. This is what Robin used in previous releases. I have updated my GitHub profile to help with any future automation.

@nehaljwani nehaljwani merged commit c60285e into Exiv2:0.27-maintenance Jan 18, 2023
@kevinbackhouse kevinbackhouse added this to the v0.27.6 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants