add support for gcc and clang 7

[neheb]

Signed-off-by: Rosen Penev [email protected]

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[codecov]

Codecov Report

Merging #2484 (f9c3e4c) into main (a7a9835) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2484   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files         121      121           
  Lines       22820    22820           
  Branches    11209    11209           
=======================================
  Hits        14174    14174           
  Misses       6439     6439           
  Partials     2207     2207           

Impacted Files	Coverage Δ
app/actions.cpp	67.91% <ø> (ø)
app/getopt.cpp	59.18% <ø> (ø)
src/basicio.cpp	51.67% <ø> (ø)
src/makernote_int.cpp	66.91% <ø> (ø)
src/futils.cpp	75.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kmilos]

Any particular reason to support these old compilers on main?

[neheb]

No. It's just real easy to do. There might be super LTS systems out there that could benefit.

[kmilos]

It's more code... and I doubt super LTS systems would go for main/next version...

[piponazo]

I love it 💯

As @neheb stated, the more compilers we can support out there the better.

However, I do not think we have CI jobs checking that clang-7 or old gcc versions can actually compile the project, right? If we want to be sure that we support these compilers we should add some additional jobs in our pipelines (we can create another ticket for that)

[neheb]

It's more code... and I doubt super LTS systems would go for main/next version...

not that much. It's just preprocessor stuff,