work around windows.h min/max macros

[neheb]

Signed-off-by: Rosen Penev [email protected]

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[codecov]

Codecov Report

Merging #2489 (39b8152) into main (527dc9f) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
- Coverage   62.12%   62.12%   -0.01%     
==========================================
  Files         121      121              
  Lines       22828    22827       -1     
  Branches    11209    11208       -1     
==========================================
- Hits        14182    14181       -1     
  Misses       6439     6439              
  Partials     2207     2207              

Impacted Files	Coverage Δ
src/basicio.cpp	51.67% <85.71%> (ø)
src/jp2image.cpp	71.24% <100.00%> (-0.07%)	⬇️
src/pngimage.cpp	62.01% <100.00%> (ø)
src/tiffcomposite_int.cpp	77.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[neheb]

So this doesn’t fix all usages but does simplify some casting and allows using auto.

[piponazo]

Can you explain here what's exactly the problem? I saw you had some problems with the Meson PR, but I do not understand what's going on ... up to now this code was compiling perfectly in all platforms. Why does it fail in meson?

[neheb]

It isn’t.

I noticed an issue where NOMINMAX has to be defined for Windows as windows.h has macros that interfere. CMake already does this. I tried to avoid it by using the template here which works but not with minmax() from numeric limits.

Basically, this is just a cleanup commit.