std::array removals

[neheb]

No description provided.

[neheb]

@kmilos should fix CLANG64 compilation.

[neheb]

From my reading of the code, Exiv2::ExifData::const_iterator evaluates to std::list::const_iterator. It's interesting that only CLANG64 on MSYS2 fails to compile.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2559 (fafd43b) into main (513b0e8) will not change coverage.
The diff coverage is 66.66%.

❗ Current head fafd43b differs from pull request most recent head 65f15a3. Consider uploading reports for the commit 65f15a3 to get more accurate results

@@           Coverage Diff           @@
##             main    #2559   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         103      103           
  Lines       22398    22398           
  Branches    10830    10830           
=======================================
  Hits        14314    14314           
  Misses       5863     5863           
  Partials     2221     2221           

Impacted Files	Coverage Δ
src/cr2image.cpp	19.04% <0.00%> (ø)
src/datasets.cpp	91.92% <ø> (ø)
src/tags.cpp	68.00% <ø> (ø)
src/tiffimage.cpp	72.34% <100.00%> (ø)
src/tiffvisitor_int.cpp	80.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kmilos]

Exiv2::ExifData::const_iterator evaluates to std::list::const_iterator

Yeah, but we're not initializing the array with the return value, but with the function pointer, no? And that's not a literal either, but should be known/constant at compile time?

Anyhow, it would good if @1div0 could spare us a minute and try main w/ -DBUILD_SAMPLES=ON on his F38 using Clang 15 as well please?

[1div0]

Exiv2::ExifData::const_iterator evaluates to std::list::const_iterator

Yeah, but we're not initializing the array with the return value, but with the function pointer, no? And that's not a literal either, but should be known/constant at compile time?

Anyhow, it would good if @1div0 could spare us a minute and try main w/ -DBUILD_SAMPLES=ON on his F38 using Clang 15 as well please?

Sure, will do in the evening or WE. 2 busy now.

[neheb]

Exiv2::ExifData::const_iterator evaluates to std::list::const_iterator

Yeah, but we're not initializing the array with the return value, but with the function pointer, no? And that's not a literal either, but should be known/constant at compile time?

Anyhow, it would good if @1div0 could spare us a minute and try main w/ -DBUILD_SAMPLES=ON on his F38 using Clang 15 as well please?

Yeah it should be. Probably a big with clang-15.

[kmilos]

LGTM, but let's not merge just yet, until @1div0 can give feedback on main as is

[neheb]

OK

[1div0]

Exiv2 LLVM 15.0.7 F38 samples.log

[neheb]

That error seems unrelated. Also, why are you building Jzon.cpp? That was removed from CMake quite a while ago.

edit:hmmm I ran that exiv2 command on my local Picture collection. I got

Uncaught exception: Overflow in Exiv2::DataBuf::c_data

in a specific folder. Can't get a backtrace with gdb for some reason.