Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson updates #2560

Merged
merged 4 commits into from
Mar 25, 2023
Merged

meson updates #2560

merged 4 commits into from
Mar 25, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 23, 2023

No description provided.

Signed-off-by: Rosen Penev <[email protected]>
Otherwise meson will not find it.

Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented Mar 23, 2023

porting tests has been a challenge.

@ghost
Copy link

ghost commented Mar 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2560 (f980928) into main (513b0e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         103      103           
  Lines       22398    22398           
  Branches    10830    10830           
=======================================
  Hits        14314    14314           
  Misses       5863     5863           
  Partials     2221     2221           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator Author

neheb commented Mar 24, 2023

@eli-schwartz I tried adding tests

--- a/meson.build
+++ b/meson.build
@@ -402,4 +402,6 @@ foreach g : gopt
   executable(g, 'samples/@[email protected]'.format(g), 'app/getopt.cpp', dependencies: exiv2_dep, include_directories: [exiv2inc, ginc])
 endforeach
 
+bindir = 'EXIV2_BINDIR=@0@'.format(meson.current_build_dir())
+subdir('tests')
 subdir('unitTests')
diff --git a/tests/meson.build b/tests/meson.build
new file mode 100644
index 000000000..4f61cd533
--- /dev/null
+++ b/tests/meson.build
@@ -0,0 +1,23 @@
+test(
+  'bugfixTests',
+  find_program('runner.py'),
+  env: bindir,
+  args: '--verbose bugfixes',
+  workdir: meson.current_source_dir(),
+)
+
+test(
+  'lensTests',
+  find_program('runner.py'),
+  env: bindir,
+  args: '--verbose lens_tests',
+  workdir: meson.current_source_dir(),
+)
+
+test(
+  'tiffTests',
+  find_program('runner.py'),
+  env: bindir,
+  args: '--verbose tiff_test',
+  workdir: meson.current_source_dir(),
+)

They end up failing. Can you look into this?

@neheb neheb merged commit b92b121 into Exiv2:main Mar 25, 2023
@neheb neheb deleted the l branch March 25, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants