Fix installation of exv_conf.h #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2017 08:28
… install destinitions in each target
|
Thanks very much for fixing this, Luis. A good start to the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to fix the way in which the autogenerated file exv_conf.h is installed.
We were assuming that the file was still in the source tree (
${CMAKE_SOURCE_DIR}/include/exiv2/exv_conf.h) while now it is in the binary dir (${CMAKE_BINARY_DIR}/exv_conf.h).I also took this opportunity to remove the usage of the global variable
INSTALL_TARGET_STANDARD_ARGS. In CMake it is better to always specify the RUNTIME, LIBRARY and ARCHIVE destinations in each target.