Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #306 #316

Merged
merged 6 commits into from
May 23, 2018
Merged

Fix issue #306 #316

merged 6 commits into from
May 23, 2018

Commits on May 23, 2018

  1. Replace '\n' by endl that flush content. Useful for debugging

    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    88ec00b View commit details
    Browse the repository at this point in the history

  2. style: Apply formatting guidelines to one-line ifs

    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    bf79396 View commit details
    Browse the repository at this point in the history

  3. debug: Add new debug message to print the PNG chunk being processed

    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    4bab67e View commit details
    Browse the repository at this point in the history

  4. Add tests for #306

    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    758a814 View commit details
    Browse the repository at this point in the history

  5. Analyze minimum needed number of null separators in PngChunk::parseTX… 

    …TChunk

This commit fixes the heap-buffer-overflow in PngChunk::parseTXTChunk.

According to the specification:
http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html

There must be 2 null separators when we start to analyze the language tag.
    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    838dee7 View commit details
    Browse the repository at this point in the history

  6. Check validity of compressionFlag & compressionMethod

    @piponazo
    piponazo committed May 23, 2018
    Configuration menu
    Copy the full SHA
    4fbfdbb View commit details
    Browse the repository at this point in the history