Prevent SIGABRT on excessive subBox length in jp2image.cpp #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 62.28% 62.51% +0.22%
==========================================
Files 150 150
Lines 20548 20550 +2
==========================================
+ Hits 12798 12846 +48
+ Misses 7750 7704 -46
Continue to review full report at Codecov.
|
piponazo
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
Thanks @rcsanchez97 for the contribution. The changes look good and CI green, let's merge the branch 😉
|
@rcsanchez97 The url to the reproducer seems familiar to me, do you happen to know which issue tracks it? |
|
@piponazo You are quite welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CVE-2018-9145
I am working on analyzing CVEs for the Debian LTS team and I believe I have identified the fix for CVE-2018-9145. Note that while I gave the MITRE URL in the test I added, the reproducer originates here: https://github.com/xiaoqx/pocs/tree/master/exiv2 (it is reproducer 4 that I used).
The fix that I applied in
jp2image.cppfollows the same pattern as the length check atjp2image.cpp:272.Also note that as a result of changes in #368 the reproducer produces the output
Uncaught exception: std::bad_allocatexiv2.cpp:177instead of aSIGABRT.If I need to adjust anything in this pull request, please let me know.