Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sigma APO MACRO 180mm F3.5 EX DG (Nikon Mount) #992

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Add Sigma APO MACRO 180mm F3.5 EX DG (Nikon Mount) #992

merged 2 commits into from
Aug 27, 2019

Conversation

sat3ll
Copy link
Contributor

@sat3ll sat3ll commented Aug 26, 2019

No description provided.

@codecov
Copy link

codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   71.09%   71.09%           
=======================================
  Files         148      148           
  Lines       19376    19376           
=======================================
  Hits        13775    13775           
  Misses       5601     5601
Impacted Files Coverage Δ
src/nikonmn_int.cpp 59.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e63e4...4329dfc. Read the comment docs.

clanmills
clanmills approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for this contribution.

@clanmills clanmills merged commit 87833d4 into Exiv2:master Aug 27, 2019
@clanmills clanmills added this to the v0.28 milestone Aug 27, 2019
clanmills added a commit that referenced this pull request Aug 27, 2019
@clanmills
fix #992
d719a81
clanmills added a commit that referenced this pull request Aug 27, 2019
@clanmills
fix #992
a49b4cb
@clanmills clanmills mentioned this pull request Aug 27, 2019
Merged
@sat3ll sat3ll deleted the sigma180.f3.5.nikon branch November 2, 2019 17:51
@clanmills clanmills mentioned this pull request Apr 27, 2020
Open
@clanmills clanmills mentioned this pull request Oct 18, 2020
Closed
@Sturmflut Sturmflut mentioned this pull request Feb 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clanmills clanmills clanmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
old-master
Development

Successfully merging this pull request may close these issues.
2 participants
@sat3ll @clanmills