Merge pull request #34 from ExpandingMan/fix-empty-prim

Fixed a bug that was preventing empty Primitives from being created

.travis.yml

@@ -30,6 +30,6 @@ matrix:
 #  - julia -e 'Pkg.clone(pwd()); Pkg.build("Arrow"); Pkg.test("Arrow"; coverage=true)'
 after_success:
   # push coverage results to Coveralls
-  - julia -e 'using Pkg; cd(Pkg.dir("Arrow")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
+  - julia --project -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
   # push coverage results to Codecov
-  - julia -e 'using Pkg; cd(Pkg.dir("Arrow")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'
+  - julia --project -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'

src/utils.jl

@@ -164,6 +164,7 @@ end
 
 # this is only for values buffers
 function check_buffer_bounds(::Type{U}, A::AbstractVector, i::Integer, len::Integer) where U
+    len == 0 && (return nothing)  # if the array being created is empty these bounds don't matter
     checkbounds(A, i)
     checkbounds(A, i+len*sizeof(U)-1)
 end

test/indexing.jl

@@ -70,6 +70,16 @@ end
 end
 
 
+@testset "indexing_Primitive_empty" begin
+    for i ∈ 1:N_OUTER
+        dtype = rand(PRIMITIVE_ELTYPES)
+        p = Primitive(dtype[])
+        @test isempty(p)
+        @test_throws BoundsError p[1]
+    end
+end
+
+
 @testset "indexing_NullablePrimitive_buffer" begin
     for i ∈ 1:N_OUTER
         len, dtype, bmask, lpad, b, v = rand_nullableprimitive_buffer()
@@ -141,6 +151,16 @@ end
 end
 
 
+@testset "indexing_NullablePrimitive_empty" begin
+    for i ∈ 1:N_OUTER
+        dtype = rand(PRIMITIVE_ELTYPES)
+        p = NullablePrimitive(dtype[])
+        @test isempty(p)
+        @test_throws BoundsError p[1]
+    end
+end
+
+
 @testset "indexing_List_buffer" begin
     len  = 5
     offstype = rand(OFFSET_ELTYPES)
@@ -183,6 +203,14 @@ end
 end
 
 
+@testset "indexing_List_empty" begin
+    for i ∈ 1:N_OUTER
+        l = List(fill("", i))
+        @test l[rand(1:i)] == ""
+    end
+end
+
+
 @testset "indexing_NullableList_buffer" begin
     len = 7
     offstype = rand(OFFSET_ELTYPES)
@@ -234,6 +262,14 @@ end
 end
 
 
+@testset "indexing_NullableList_empty" begin
+    for i ∈ 1:N_OUTER
+        l = NullableList(fill("", i))
+        @test l[rand(1:i)] == ""
+    end
+end
+
+
 @testset "indexing_BitPrimitive_buffer" begin
     len = 10
     bits = vcat(UInt8[0xfd,0x02], zeros(UInt8, 6))