-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change background color of focus element #51158
base: main
Are you sure you want to change the base?
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2024-10-21_15.00.36.mp4Android: mWeb Chromeandroid-chrome-2024-10-21_14.57.41.mp4iOS: Nativeios-app-2024-10-21_15.11.00.mp4iOS: mWeb Safariios-safari-2024-10-21_15.12.24.mp4MacOS: Chrome / Safaridesktop-chrome-2024-10-21_13.40.38.mp4MacOS: Desktopdesktop-app-2024-10-21_13.49.14.mp4 |
@shawnborton Here's a bit more detail on how it looks for the account switcher: desktop-chrome-account-switcher-2024-10-21_13.43.35.mp4 |
desktop-chrome-account-switcher-maybe-bug-2024-10-21_13.56.25.mp4 |
desktop-chrome-account-switcher-bug-2024-10-21_13.55.29.mp4 |
Yeah, it seems like from your video that the :hover style doesn't override the .active style of the currently selected option row. So I am thinking we should reuse that same behavior here for the keyboard navigation as well. |
Details
Fixed Issues
$ #50779
PROPOSAL: #50779 (comment)
Tests
Offline tests
same as above
QA Steps
same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web-resize.mp4
MacOS: Desktop
desktop.mov