Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "React Native Render HTML: whitespace collapsing" #876

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Revert "React Native Render HTML: whitespace collapsing" #876

merged 1 commit into from
Dec 2, 2020

Conversation

AndrewGable
Copy link
Contributor

Reverts #851

cc @jsamr

Reverting due to error found on production via loading a new chat.

text-transforms.js:19 Uncaught SyntaxError: Invalid regular expression: /([⺀-⻿⼀-⿟⿰-⿿　-〿�-ゟ゠-ヿ㄰-��-㆟㇀-㇯ㇰ-ㇿ㌀-��-䶿一-鿿ꀀ-��-�豈-﫿�-︟︰-��-﹯＀-￯])
([⺀-⻿⼀-⿟⿰-⿿　-〿�-ゟ゠-ヿ㄰-��-㆟㇀-㇯ㇰ-ㇿ㌀-��-䶿一-鿿ꀀ-��-�豈-﫿�-︟︰-��-﹯＀-￯])/: Range out of order in character class
    at new RegExp (<anonymous>)
    at Object.<anonymous> (text-transforms.js:19)
    at n (bootstrap:19)
    at Object.<anonymous> (collapse.js:14)
    at n (bootstrap:19)
    at Object.<anonymous> (TRenderEngine.js:8)
    at n (bootstrap:19)
    at Object.<anonymous> (index.js:170)
    at n (bootstrap:19)
    at Object.<anonymous> (TNodeRenderer.js:10)

Screen Shot 2020-12-02 at 2 52 32 PM

@AndrewGable AndrewGable requested a review from a team as a code owner December 2, 2020 21:52
@AndrewGable AndrewGable self-assigned this Dec 2, 2020
@botify
Copy link

botify commented Dec 2, 2020

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@botify botify requested review from thienlnam and removed request for a team December 2, 2020 21:53
@coleaeason coleaeason merged commit 609b0dc into master Dec 2, 2020
@coleaeason coleaeason deleted the revert-851-jsamr-whitespace-collapsing branch December 2, 2020 21:55
@jsamr jsamr mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coleaeason coleaeason coleaeason approved these changes

@thienlnam thienlnam Awaiting requested review from thienlnam

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewGable @botify @coleaeason