Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emoji font size if it was updated in markdownStyle #475

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Update emoji font size if it was updated in markdownStyle #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b77f34
Update emoji font size if it was updated in markdownStyle
VickyStash Sep 9, 2024
b36094c
re-run checks
VickyStash Sep 10, 2024
de00fff
Merge branch 'refs/heads/main' into bugfix/fix-emoji-font-size-change
VickyStash Sep 12, 2024
748b93c
Add missing indentation
VickyStash Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ios/MarkdownTextInputDecoratorView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,17 @@ - (void)setMarkdownStyle:(RCTMarkdownStyle *)markdownStyle
_markdownStyle = markdownStyle;
[_markdownUtils setMarkdownStyle:markdownStyle];

// apply new styles
if (_textView != nil) {
// We want to use `textStorage` for applying markdown when possible. Currently it's only available for UITextView
[_textView textDidChange];
} else {
// apply new styles
#ifdef RCT_NEW_ARCH_ENABLED
[_textInput _setAttributedString:_backedTextInputView.attributedText];
[_textInput _setAttributedString:_backedTextInputView.attributedText];
#else
[_textInput setAttributedText:_textInput.attributedText];
[_textInput setAttributedText:_textInput.attributedText];
#endif /* RCT_NEW_ARCH_ENABLED */
}
}

@end
4 changes: 4 additions & 0 deletions ios/RCTUITextView+Markdown.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

NS_ASSUME_NONNULL_BEGIN

@interface RCTUITextView (Private)
- (void)textDidChange;
@end

@interface RCTUITextView (Markdown)

@property(nonatomic, nullable, getter=getMarkdownUtils) RCTMarkdownUtils *markdownUtils;
Expand Down
Loading