Fix: Client getMyUserIdx always returns -1 #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getMyUserIdx
always returns-1
/#
Solution
/#
from the if statement as the arrayusers
contains the socket ids without/#
/#
from any other place so it doesn't cause confusion due that the issue was solved by socket.io stop prepend /# before id when no namespace socketio/socket.io#2509Comments
The
/#
was something introduced in version1.4.0
of socket.io as stated here socketio/socket.io#2405