Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tokens, util classes for our415; modify theme #21

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

kramduckner
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses issue ticket

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

The motivation behind this is try to get the team on a good footing re: global styles + theme. There was a lot to consider when this was done: trying to merge the design system used for our415 designs with AskDarcelWeb, a long term strategy for a merge with the origin repo, building something fast enough for the MVP, etc. What I settled on was trying to accomplish two goals:

  1. build utils and tokens for the remaining work for the MVP
  2. leverage the current theming tools AskDarcel to be in line with the utils and tokens built for our415 so the spacing, typography, color palette etc in the askdarcel web components looks inline with the our415 site. There's still work to be done here, especially at the component level, but this PR seeks to update all of the styles at the global level.

I don't like this as a long term approach, but until we figure our relationship with the origin fork, I want to keep changes minimal. The design systems between our415 and sfservice don't match, so the implemented theming system is going to be a bit messy until we can figure out a path to consolidation or decide not to consolidate. I'm also worried about the time it would take to build a really thoughtful theming system since the timeline is tight.

How Can This Be Tested/Reviewed?

  • Make sure app builds
  • Check the styles in figma and ensure we have a good system to match it
  • Check the figma styleguide and make sure we have good coverage for tokens, classes, etc
  • Ensure that the changes to the AskDarcel theming make sense

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have assigned reviewers
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@kramduckner kramduckner merged commit 328651a into development Jun 3, 2024
2 checks passed
@kramduckner kramduckner deleted the base-style-update branch June 3, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant