Adds component markup for logo and dropdown menus using Strapi data for desktop #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosschapman
commented
Jul 1, 2024
| @@ -70,7 +70,7 @@ module.exports = { | |||
| "@typescript-eslint/no-unsafe-call": "off", | |||
| "@typescript-eslint/no-unsafe-member-access": "off", | |||
| "@typescript-eslint/no-unsafe-return": "off", | |||
| "@typescript-eslint/no-unused-vars": "error", | |||
| "@typescript-eslint/no-unused-vars": ["error", { "ignoreRestSiblings": true }], | |||
There was a problem hiding this comment.
Allows clever removal of properties from an object with destructuring. I'm open to debate on it, although to me it feels restricted when the intent of this type of code is quite clear. See example below.
There was a problem hiding this comment.
This approach works for me!
rosschapman
commented
Jul 1, 2024
Comment on lines
-31
to
-45
| const SiteLogo = () => ( | ||
| <Link className={`${styles.navLogo}`} to="/"> | ||
| {/* TODO */} | ||
| [SITE LOGO HERE] | ||
| </Link> | ||
| ); | ||
|
|
||
| const SiteLinks = () => { | ||
| return ( | ||
| <div className={styles.navRight}> | ||
| <Translate /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
It could be worth separating these out later but I didn't see much use for this abstraction at the moment while I was rewriting things.
rosschapman
changed the title
rosschapman
changed the title
adriencyberspace
approved these changes
Jul 2, 2024
| @@ -70,7 +70,7 @@ module.exports = { | |||
| "@typescript-eslint/no-unsafe-call": "off", | |||
| "@typescript-eslint/no-unsafe-member-access": "off", | |||
| "@typescript-eslint/no-unsafe-return": "off", | |||
| "@typescript-eslint/no-unused-vars": "error", | |||
| "@typescript-eslint/no-unused-vars": ["error", { "ignoreRestSiblings": true }], | |||
There was a problem hiding this comment.
This approach works for me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on markup. Demo:
Monosnap.screencast.2024-07-01.13-55-44.mp4