Back Navigation/Favicon/Home page Icon #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosschapman
reviewed
Jul 1, 2024
Comment on lines
+19
to
+21
| const backDestination = defaultReturnTo | ||
| ? () => history.push(defaultReturnTo) | ||
| : () => history.goBack(); |
There was a problem hiding this comment.
I think this simplification works. However, in order to cover all use cases as defined by our decision table, let's make defaultReturnTo required.
rosschapman
reviewed
Jul 1, 2024
| }: { | ||
| defaultReturnTo: string; | ||
| defaultReturnTo?: string; |
There was a problem hiding this comment.
Per suggestion to make this required, can we use PropTypes in functional components? It's been a while since I did this.
Suggested change
| defaultReturnTo?: string; | |
| defaultReturnTo: PropTypes.string.isRequired. |
rosschapman
reviewed
Jul 1, 2024
|
|
||
| return ( | ||
| <Button onClick={backDestination} variant="linkWhite" arrowVariant="before"> | ||
| Back to Service Listings | ||
| {content} |
There was a problem hiding this comment.
What do you think about making this the implicit {children} passed in as a block to allow for more flexibility?
rosschapman
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR:
How Can This Be Tested/Reviewed?