Skip to content

Commit

Permalink
usb: gadget: function: f_fs: pass companion descriptor along
Browse files Browse the repository at this point in the history
commit 2bfa0719ac2a9b2f3c91345873d3cdebd0296ba9 upstream.

If we're dealing with SuperSpeed endpoints, we need
to make sure to pass along the companion descriptor
and initialize fields needed by the Gadget
API. Eventually, f_fs.c should be converted to use
config_ep_by_speed() like all other functions,
though.

Signed-off-by: Felipe Balbi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Change-Id: Ic0ac8b6f0a683f649494ac4b3f4965c52365e555
  • Loading branch information
Felipe Balbi authored and SiddhantNaik17 committed Jan 20, 2019
1 parent 7cd8a13 commit d97d465
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions drivers/usb/gadget/function/f_fs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1649,11 +1649,14 @@ static int ffs_func_eps_enable(struct ffs_function *func)
spin_lock_irqsave(&func->ffs->eps_lock, flags);
do {
struct usb_endpoint_descriptor *ds;
struct usb_ss_ep_comp_descriptor *comp_desc = NULL;
int needs_comp_desc = false;
int desc_idx;

if (ffs->gadget->speed == USB_SPEED_SUPER)
if (ffs->gadget->speed == USB_SPEED_SUPER) {
desc_idx = 2;
else if (ffs->gadget->speed == USB_SPEED_HIGH)
needs_comp_desc = true;
} else if (ffs->gadget->speed == USB_SPEED_HIGH)
desc_idx = 1;
else
desc_idx = 0;
Expand All @@ -1670,6 +1673,14 @@ static int ffs_func_eps_enable(struct ffs_function *func)

ep->ep->driver_data = ep;
ep->ep->desc = ds;

comp_desc = (struct usb_ss_ep_comp_descriptor *)(ds +
USB_DT_ENDPOINT_SIZE);
ep->ep->maxburst = comp_desc->bMaxBurst + 1;

if (needs_comp_desc)
ep->ep->comp_desc = comp_desc;

ret = usb_ep_enable(ep->ep);
if (likely(!ret)) {
epfile->ep = ep;
Expand Down

0 comments on commit d97d465

Please sign in to comment.