fix: New UI: bug sourceId not setting correctly (#85)

* fix: bug sourceId not setting correctly * fix: prettier test fail
Eyevinn · Nov 8, 2024 · ba606a5 · ba606a5
1 parent ab4b87b
commit ba606a5
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/src/app/api/manager/ingests/source_id/[ingest_name]/[ingest_source_name]/route.ts b/src/app/api/manager/ingests/source_id/[ingest_name]/[ingest_source_name]/route.ts
@@ -21,9 +21,14 @@ export async function GET(
   }
 
   try {
-    const ingestUuid = await getUuidFromIngestName(params.ingest_name);
+    const ingestUuid = await getUuidFromIngestName(params.ingest_name, false);
+
     const sourceId = ingestUuid
-      ? await getSourceIdFromSourceName(ingestUuid, params.ingest_source_name)
+      ? await getSourceIdFromSourceName(
+          ingestUuid,
+          params.ingest_source_name,
+          false
+        )
       : 0;
     return new NextResponse(JSON.stringify(sourceId), { status: 200 });
   } catch (error) {

diff --git a/src/components/modal/ConfigureAlignmentLatencyModal.tsx b/src/components/modal/ConfigureAlignmentLatencyModal.tsx
@@ -4,7 +4,7 @@ import { Button } from '../button/Button';
 import { Loader } from '../loader/Loader';
 import { ISource } from '../../hooks/useDragableItems';
 import { useState, useEffect, useRef } from 'react';
-import { useIngestStreams } from '../../hooks/ingests';
+import { useIngestStreams, useIngestSourceId } from '../../hooks/ingests';
 import { useGetProductionSourceAlignmentAndLatency } from '../../hooks/productions';
 import {
   ResourcesCompactPipelineResponse,
@@ -73,6 +73,7 @@ export function ConfigureAlignmentLatencyModal({
   const [showRestartStreamModal, setShowRestartStreamModal] =
     useState<boolean>(false);
   const [inputErrors, setInputErrors] = useState<Record<string, boolean>>({});
+  const [getIngestSourceId] = useIngestSourceId();
 
   const t = useTranslate();
   const getIngestStreams = useIngestStreams();
@@ -99,6 +100,18 @@ export function ConfigureAlignmentLatencyModal({
     }
   }, [pipelinesAreSelected, latencies, alignments]);
 
+  useEffect(() => {
+    const fetchSourceId = async () => {
+      const sourceId = await getIngestSourceId(
+        source.ingest_name,
+        source.ingest_source_name
+      );
+      setSourceId(sourceId);
+    };
+
+    fetchSourceId();
+  }, [source]);
+
   useEffect(() => {
     const fetchStreams = async () => {
       try {
@@ -132,7 +145,6 @@ export function ConfigureAlignmentLatencyModal({
             newAlignments[stream.pipeline_uuid] = 0;
             newLatencies[stream.pipeline_uuid] = 0;
           }
-          setSourceId(stream.source_id);
         }
       } else if (availablePipelines) {
         for (const pipeline of availablePipelines) {

diff --git a/src/components/sourceCard/SourceCard.tsx b/src/components/sourceCard/SourceCard.tsx
@@ -57,7 +57,10 @@ export default function SourceCard({
   const { locked } = useContext(GlobalContext);
 
   const pipelinesAreSelected =
-    pipelines.some((pipeline) => pipeline.pipeline_id === undefined) === false;
+    pipelines.some(
+      (pipeline) =>
+        pipeline.pipeline_id === undefined || pipeline.pipeline_id === ''
+    ) === false;
 
   const updateText = (event: ChangeEvent<HTMLInputElement>) => {
     setSourceLabel(event.currentTarget.value);