Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sources not being removed from pipeline #77

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Saelmala
Copy link

@Saelmala Saelmala commented Nov 5, 2024

There was a problem before that if you removed a source from a RUNNING production, the source was removed only from production.sources but not from production.production_settings.pipelines.pipeline.sources, this PR solves that.

@Saelmala Saelmala self-assigned this Nov 5, 2024
Copy link

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saelmala Saelmala merged commit 92e1109 into main Nov 6, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/sources-not-being-removed-from-pipeline branch November 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants