Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to send process-compose to background #163

Closed
teto opened this issue Mar 20, 2024 · 8 comments
Closed

possibility to send process-compose to background #163

teto opened this issue Mar 20, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@teto
Copy link

teto commented Mar 20, 2024

Feature Request

I like sending the current program to the background with Ctrl+Z so that I can quickly cheeck something in the current directory and put back the program to foreground with fg.
process-compose seems to catch the Ctrl-z signal and does nothing with it ?

Who Benefits From The Change(s)?

Probably not everyone

@F1bonacc1 F1bonacc1 added the enhancement New feature or request label Mar 22, 2024
@F1bonacc1
Copy link
Owner

Added in v1.0.0.
CTRL-B to send to the background, exit the shell (CTRL-D) to return.

@teto
Copy link
Author

teto commented Mar 23, 2024

wonderful. the default binding to send to background is usually Ctrl-Z, could it be made the default instead ?

@F1bonacc1
Copy link
Owner

Sure, you can change it in your shortcuts.yaml.

@teto
Copy link
Author

teto commented Mar 23, 2024

I know but is there a compelling reason for upstream to use a different default than 99% of all software ?

@F1bonacc1
Copy link
Owner

The implementation is slightly different than sigtstp and sigcont. Since I want the process to keep running and receive cpu time.
Do you think it should be suspended like programs that are sent to the background with CTRL-Z?

@teto
Copy link
Author

teto commented Mar 23, 2024

If the behavior is different, I understand better your choice. As you mentioned it can be overriden

Since I want the process to keep running and receive cpu time.

why do we need that ? for the probes to run ?

@F1bonacc1
Copy link
Owner

That's right:

  • probes
  • log aggregation and rotation
  • API server
  • processes orchestration

@teto
Copy link
Author

teto commented Mar 23, 2024

great thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants