Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework nix instructions now that nixpkgs has it #28

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

thenonameguy
Copy link
Contributor

now that this project is packaged in the main nixpkgs repostitory
the need for instructing people to compile from source is unnecessary.

I'm also proposing changes to include process-compose as a built-in component in this project:
https://devenv.sh/
cachix/devenv#78

The above would solve problems like #14
and provide nice common service descriptions for common architectural components (postgres/kafka/redis/etc.).

Might be worth mentioning in the README.md once the above issue is resolved.

default.nix Show resolved Hide resolved
@F1bonacc1
Copy link
Owner

F1bonacc1 commented Nov 20, 2022

Hey @thenonameguy,

I gave it a little more thought. You don't need to change your PR. I will initialize the string (it has to be string) flag to be "false", so if you pass nothing we will get the desired behavior.
I will update my makefile to pass "true", of course.

@F1bonacc1 F1bonacc1 merged commit 9196745 into F1bonacc1:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants