Add guards to verify that the unit instance still exists #6342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Fixes a rather invisible bug from #6263 .
The logging when the
pcall
fails is disabled at the moment. Luckily, the errors are caught and registered by the c-debugger. The tables with unit references in them are cleaned up automagically by the garbage collector, but there can be a few ticks in between the unit dying and the unit being collected. In those few ticks it can generate various errors.Checklist
Changes are annotated, including comments where useful