FA M3 Red Dawn: Fix bug with 1st mission completion due to external factories #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following FAF changes introducing external factory units, these get included as part of the objective to be destroyed, but the objective doesn't complete when the parent unit is destroyed (presumably the OnKilled callback doesnt trigger for the external factory when it is removed due to the parent dying) Fix is to just exclude external factories from the list of units added to the objective.
maudlin27
changed the title
|
I thought I fixed this, the callbacks should trigger with the latest hot fix |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following FAF changes introducing external factory units, these get included as part of the objective to be destroyed, but the objective doesn't complete when the parent unit is destroyed (presumably the OnKilled callback doesnt trigger for the external factory when it is removed due to the parent dying) Fix is to just exclude external factories from the list of units added to the objective.