Cybran M4 - fix bug where M2 can be completed before it has started #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed2CZ
reviewed
Feb 18, 2024
| ScenarioFramework.Dialogue(OpStrings.C04_M02_040) | ||
| else | ||
| Objectives.UpdateBasicObjective(ScenarioInfo.M2S1Objective, 'description', LOCF(OpStrings.M2S1Fail, 80)) | ||
| if not(ScenarioInfo.M2P1Started == true) then |
There was a problem hiding this comment.
can you reverse this condition to
if ScenarioInfo.M2P1Started then
return
end
ScenarioInfo.M2P1Started = trueto avoid unnecessary nesting
When testing to fix another (more common) issue I ran into the scenario where it tried completing mission 2 before it had started mission 2. This adds a redundancy to call the start of M2 first in this scenario, while also avoiding triggering the start of M2 multiple times as a result of the redundancy
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing to fix another (more common) issue I ran into the scenario where it tried completing mission 2 before it had started mission 2. This adds a redundancy to call the start of M2 first in this scenario, while also avoiding triggering the start of M2 multiple times as a result of the redundancy