Use hmac token for ergochat authentication due to irc 510 message character limit #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
force-pushed
the
feature/ergochat-hmac
branch
2 times, most recently
from
8b9074f
to
312a41f
Compare
Sheikah45
force-pushed
the
feature/ergochat-hmac
branch
from
312a41f
to
e96de6b
Compare
Brutus5000
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRC limits messages to 510. OAuth JWT tokens exceed that limit so can't be used for authentication.
For that reason we could instead use an hmac token with the account name encoded as the message that can then be verified by ergo chat.