Update dependencies and adjust code #585
Conversation
Askaholic
force-pushed
the
issue/#584-update-dependencies
branch
2 times, most recently
from
5bf1ec3
to
87661de
Compare
|
|
||
| await db.close() |
There was a problem hiding this comment.
Well, I wish, we work with database without dirtying it.
Like it's here.
https://github.com/norraxx/faf-aio-replayserver/blob/master/tests/fixtures/db_fixtures.py#L7
There was a problem hiding this comment.
And ofc IF we have .commit() in code, we should mock it.
There was a problem hiding this comment.
The database connection used during tests gets rolled back. This one is just for loading the test-data file once at the start of the session. And for some reason with the newest version of pytest-asyncio having an asyc finalizer on this session scoped fixture would throw an error due to closed event loop.
There was a problem hiding this comment.
Do we also rollback these changes?
There was a problem hiding this comment.
No, the test data is not rolled back
Askaholic
force-pushed
the
issue/#584-update-dependencies
branch
from
87661de
to
35b0bdc
Compare
Askaholic
force-pushed
the
issue/#584-update-dependencies
branch
from
35b0bdc
to
e660f2e
Compare
* Update dependencies and adjust code * Ignore hypothesis deprecation warnings on a per test basis * Make devserver command use `dev-config.yml` file.
Adjusting a few fixtures to get around the event loop being closed problem. I also ignore some deprecation warnings in the tests because they do not cause us any issues.
Closes #584.