Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#449 remove npm lock #450

Closed
wants to merge 2 commits into from

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 9, 2023

closes #449

non critical, since this is ignored anyways in the build.
dependabot should also

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 9, 2023

dependabot is also fixed with that (was picking up updates of packages, that are not used in the image)

@Brutus5000
Copy link
Member

Brutus5000 commented Nov 10, 2023

Shouldn't we do it the other way round and make sure the build process considers the lock file?

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 10, 2023

already a fix for this on the way.

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 10, 2023

we are using yarn, so only the "yarn.lock" is used. the package-lock is unused (maybe some dev was executing npm install instead of yarn install).
since there is no check in the Dockerfile with --frozen-lockfile, the yarn installation was only complaining about it with:

"warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json."

@Sheikah45
Copy link
Member

This is no longer required correct?

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 11, 2023

correct

@fcaps fcaps closed this Nov 11, 2023
@fcaps fcaps deleted the bugfix/#449-remove-npm-lock branch November 11, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cleanup] remove npm lock
3 participants