Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXdispersion refinements #19

Merged
merged 6 commits into from
Feb 8, 2023
Merged

NXdispersion refinements #19

merged 6 commits into from
Feb 8, 2023

Conversation

domna
Copy link

@domna domna commented Feb 2, 2023

@domna domna marked this pull request as ready for review February 8, 2023 13:57
Copy link

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have the respective yaml files already in the subdirectory nyaml?

@domna
Copy link
Author

domna commented Feb 8, 2023

They probably are but not their updated versions, since they were kept in a branch at data-modeling.
I'll rebase this branch and add the updated yml versions.

@domna
Copy link
Author

domna commented Feb 8, 2023

@sanbrock Now all the yaml and nxdl files are up to date

@RubelMozumder
Copy link

Yes, I think your files are going to the right directory. So, @domna you can merge.

@domna domna merged commit 2cc9d98 into fairmat Feb 8, 2023
@domna domna deleted the dispersion-refinements branch February 8, 2023 17:37
@sanbrock
Copy link

sanbrock commented Feb 8, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants