Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXsource: type extended, previous_source added #299

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

lukaspie
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I would restrict types of Sources in the appdef more to optics.

@lukaspie lukaspie changed the title Nxsource type NXsource: type extended, previous_source added Sep 24, 2024
@lukaspie lukaspie merged commit 78e7b5f into fairmat Sep 24, 2024
7 checks passed
@lukaspie lukaspie deleted the nxsource-type branch September 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants