Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally demand hyperspy version 1.7.6 if python is 3.12 #80

Open
mkuehbach opened this issue Oct 16, 2024 · 1 comment
Open

Conditionally demand hyperspy version 1.7.6 if python is 3.12 #80

mkuehbach opened this issue Oct 16, 2024 · 1 comment

Comments

@mkuehbach
Copy link
Collaborator

mkuehbach commented Oct 16, 2024 •
edited
Loading

Related to pyxem/kikuchipy#682, given that pynxtools-em currently uses pyxem and kikuchipy for py3.12 indeed there are cases where hyperspy 1.7.5 version gets chosen.

Suggestion to fix it for now via making hyperspy==1.7.6 required until fixed on hyperspy's end.
https://peps.python.org/pep-0633/
@mkuehbach mkuehbach changed the title Demand specific hyperspy version 1.7.6 Conditionally demand hyperspy version 1.7.6 if python is 3.12 Oct 16, 2024
@mkuehbach
Copy link
Collaborator Author

mkuehbach commented Oct 16, 2024 •
edited
Loading

conditional dependency to be added in pyproject.toml
hyperspy = { version = "== 1.7.6", markers = "python_version >= '3.12'" }

mkuehbach pushed a commit that referenced this issue Oct 25, 2024
@atomprobe-tc
Fix #80, which is a temporary fix until the hyperspy developers fix #71…
f51e020 
… on their side
@mkuehbach mkuehbach mentioned this issue Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkuehbach