Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declutter kwargs in convert_cli #410

Open
lukaspie opened this issue Aug 23, 2024 · 1 comment
Open

Declutter kwargs in convert_cli #410

lukaspie opened this issue Aug 23, 2024 · 1 comment

Comments

@lukaspie
Copy link
Collaborator

In #404, we used a workaroung to add config_file to the kwargs (it is an input to thie `convert_cli? function).

if config_file:
    kwargs["config_file"] = config_file

Actually, this whole discussion is part of a bigger problem, namely that we call

data = data_reader().read(  # type: ignore[operator]
        template=Template(template), file_paths=input_file, **kwargs
    )

in the convert function. But, most of our reader don't actually accept kwargs, so this will always be a bit unstable. We should fix the kwargs downstream passing and general argument handling.

@lukaspie
Copy link
Collaborator Author

Relevant discussion here: #404 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant