Suggestion for fixing the unintentional situation that since v0.6 the… #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dataconverter required a config file if it was called the classical way and in case no parameter yaml file was provided. For programmatically use of the converter the creation of an additional params file with only a few entries is unnecessary overhead especially when all cli arguments are available in the callers scope and thus the CLI call can be issues directly using the classical way dataconverter convert [INPUTFILES] options
mkuehbach
requested review from
sherjeelshabih and
lukaspie
and removed request for
sherjeelshabih
|
I also removed the outdated documentation of the command line options as it is a second place where changes have to be applied constantly and the instructions for empowering people to find these are already given in the readme plus follow the typical style how to get help for command line calls |
mkuehbach
commented
Aug 21, 2024
…is passed via cli but instead have their own configurations for the respective formats they support as part of the plugin source code, hence calling these readers with kwargs config is unnecessary and incorrect, this commit fixes this bug
sherjeelshabih
previously requested changes
Aug 21, 2024
|
Tested 30ad68c of this branch solves the problems @sherjeelshabih |
lukaspie
reviewed
Aug 22, 2024
lukaspie
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
I tested with
pynxtools-xps, both with and w/o a config filepyntools-mpes, always uses config filepynxtools-stmpynxtools-em, with the example @mkuehbach send mejson_map-> with examples inexample/json-map
@mkuehbach feel free to merge if your examples still run through (wasn't sure if you tested something else as well). Thanks for the fix!
mkuehbach
dismissed
sherjeelshabih’s stale review
Outdated conflicts were resolved
RonHildebrandt
pushed a commit
that referenced
this pull request
Aug 30, 2024
lukaspie
pushed a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… dataconverter required a config file if it was called the classical way and in case no parameter yaml file was provided. For programmatically use of the converter the creation of an additional params file with only a few entries is unnecessary overhead especially when all cli arguments are available in the callers scope and thus the CLI call can be issues directly using the classical way dataconverter convert [INPUTFILES] options