Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes asterisk notation for mpes reader #236

Closed
wants to merge 1 commit into from

Conversation

domna
Copy link
Collaborator

@domna domna commented Feb 12, 2024

This PR should enable proper collection of axis names from xarray.
We use an asterisk for this to create key-value pairs:

"/ENTRY[entry]/data": {
    "@axes": "@data:dims",
    "AXISNAME_indices[@*_indices]": "@data:*.index",
    "@signal": "data",
    "data": "@data:data",
    "data/@units": "counts",
    "AXISNAME[*]": "@data:*.data",
    "AXISNAME[*]/@units": "@data:*.unit",
    "energy/@type": "binding"
  }

, which creates, e.g., AXISNAME[energy] = @data:energy.data for all names in the data array.
We however, would like to be able to rename the key manually or enter a different value for the key. So if either the value or the key are present in the file the automatism should not write this particular entry. This manual overwriting does not work properly and needs to be fixed.

@domna domna self-assigned this Feb 12, 2024
@domna domna requested a review from rettigl February 12, 2024 07:22
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7868474982

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.584%

Totals Coverage Status
Change from base Build 7830110631: 0.0%
Covered Lines: 4906
Relevant Lines: 11004

💛 - Coveralls

@domna domna assigned domna and unassigned domna Feb 20, 2024
@domna
Copy link
Collaborator Author

domna commented Feb 20, 2024

This will be fixed in FAIRmat-NFDI/pynxtools-mpes#1

@domna domna closed this Feb 20, 2024
@domna domna deleted the fix-mpes-reader-asterisk branch February 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants