Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise topology construction #2306

Merged
merged 43 commits into from
Aug 17, 2022
Merged

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Aug 1, 2022

Generalise construction of topology, specifically with respect to ghost cells.

  • allows the partitioner to return any set of destinations for each cell
  • changes the way Topology is computed, without relying on a band of ghost cells to find the interface between processes
  • stores the interface between processes as interprocess_facets in Topology
  • removes some assumptions about symmetry in MPI comms
  • corrects many errors in comments
  • removes some dead code from Topology construction

This may not be a fully complete set of changes required. Additional changes for a subsequent PR:

  • fully check over the assumptions in creating shared vertices
  • remove GhostMode entirely, leave it up to the partitioner (provide user with built-in partitioners for no ghosting, or facet based)
  • provide a utility to compute boundary vertices of a topology

@chrisrichardson chrisrichardson marked this pull request as ready for review August 16, 2022 08:40
Copy link
Member

@jpdean jpdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants