-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend VectorFunctionSpace to custom elements #2576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work for Basix UFL element, so I've added code suggestions changing the type to basix.ufl_wrapper._BasixElementBase
. (The suggestions might need adjusting to make flake8 pass, getting the number of spaces right in this interface is hard.)
Co-authored-by: Matthew Scroggs <[email protected]>
Ok great, thank you. I adjusted the spaces. |
By the way, I took the line that you improved from the definition of the FunctionSpace class: line 470. Wouldn't it be relevant to also apply your change there (I won't do it)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested renaming to get mypy to pass
Ok great, and thank you for the mypy fix. Is there anything else I should do? (Close the PR?) Or just wait for you/someone else to merge? |
Just wait for someone to merge |
This PR would resolve #2557