-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bounding box leaf collision check #2850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
requested review from
garth-wells,
chrisrichardson,
IgorBaratta and
nate-sime
November 2, 2023 07:41
garth-wells
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the PR have a more descriptive title?
And could a test be added?
jorgensd
commented
Nov 2, 2023
jorgensd
commented
Nov 2, 2023
garth-wells
approved these changes
Nov 2, 2023
IgorBaratta
approved these changes
Nov 2, 2023
nate-sime
approved these changes
Nov 2, 2023
@garth-wells Test added + minor simplification. Feel free to merge this once the CI passes. |
jhale
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Check leaf collision * Reviewer comments * Fix the fix * Apply suggestions from code review * Make logic clearer * Readability fix * Remove superfluous variable * Add test --------- Co-authored-by: Garth N. Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @nate-sime
The following MWE produces the wrong collision for the global_bb_tree
giving the following in serial:
and the correct result in parallel
This is due to a bug in
_compute_collisions_point
where we don't check if the leaf node actually collides with the point.@massimiliano-leoni could you see if this impacts your mesh interpolation (in serial)? As the
global_bb_tree
is used it would add any interpolation point from the other mesh to the process, even if it doesn't collide.